KarshVashi opened a new pull request, #67876:
URL: https://github.com/apache/airflow/pull/67876
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Five Redshift cluster triggers (`RedshiftCreateClusterTrigger`,
`RedshiftPauseClusterTrigger`,
`RedshiftCreateClusterSnapshotTrigger`, `RedshiftResumeClusterTrigger`,
`RedshiftDeleteClusterTrigger`)
did not forward `verify`, `botocore_config`, or even `region_name` to the
hook, so deferrable
Redshift operators silently dropped custom SSL, botocore, and region
settings when polling
AWS from the triggerer.
Follows the same pattern as the AWS Batch triggers migration (#67508) and
the Lambda trigger
(`providers/amazon/src/airflow/providers/amazon/aws/triggers/lambda_function.py`).
**What this changes:**
- Adds `**kwargs` passthrough in all five trigger `__init__` methods so
base-class params
(`verify`, `botocore_config`) reach `AwsBaseWaiterTrigger`
- Adds `region_name` as an explicit parameter (previously not forwarded to
the hook at all)
- Updates all five `hook()` methods to pass `region_name`, `verify`, and
`botocore_config`
to `RedshiftHook`
- Updates operator defer sites in `redshift_cluster.py` to forward these
params
- Adds parametrized test coverage for serialization and hook propagation
across all five triggers
`RedshiftClusterTrigger` is intentionally out of scope — it uses a custom
polling loop with
`BaseTrigger` directly and a dynamic `target_status` rather than a single
waiter, so migrating
it would require introducing custom waiters per state (noted by @dominikhei
on #35278).
Part of #35278
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
