rahul-madaan opened a new pull request, #67894:
URL: https://github.com/apache/airflow/pull/67894
`DatabricksSubmitRunOperator` previously emitted no OpenLineage information.
This
adds optional injection of OpenLineage **parent job** and **transport**
configuration into the submitted job's `new_cluster.spark_conf`, so the
Spark job
running on the Databricks cluster can correlate its lineage events with the
triggering Airflow task and ship them to the same OpenLineage backend.
This mirrors the existing automatic-injection support in the Dataproc, EMR
(Serverless / on-EKS) and Glue operators.
### What changed
- Two new parameters on `DatabricksSubmitRunOperator`:
- `openlineage_inject_parent_job_info` — injects
`spark.openlineage.parentJobNamespace/parentJobName/parentRunId` and
the
`rootParent*` properties.
- `openlineage_inject_transport_info` — injects the
`spark.openlineage.transport.*`
properties.
Each defaults to the corresponding
`openlineage.spark_inject_parent_job_info` /
`openlineage.spark_inject_transport_info` config option, so injection
can be
enabled globally or per-operator (matching the other operators).
- A provider-local helper
`inject_openlineage_properties_into_databricks_job` that
reuses the shared `inject_*_into_spark_properties` helpers (via
`apache-airflow-providers-common-compat`) and handles both the
single-task
(top-level `new_cluster`) and multi-task (`tasks[].new_cluster`) forms.
- Injection is safely skipped when the OpenLineage provider is
unavailable, when the
relevant `spark.openlineage.*` properties are already present, or when
the job has
no `new_cluster` to modify (e.g. it targets an `existing_cluster_id`).
Existing
`spark_conf` entries are preserved.
### Scope
This PR covers `DatabricksSubmitRunOperator`. `DatabricksRunNowOperator`
triggers a
pre-defined job and therefore has no `new_cluster` to inject into — its
only
injection surface is `spark_submit_params` (a different, list-of-strings
shape), so
it is intentionally not part of this change.
### Tests
- Unit tests for the operator (parent-only, transport-only, both, disabled,
preserves existing `spark_conf`) and for the helper's traversal
(single-task,
multi-task, existing-cluster skip, provider-inaccessible,
no-mutation-of-input).
- Verified on a real Databricks workspace that a `runs/submit` payload
carrying the
injected `spark.openlineage.*` properties is accepted and the properties
round-trip
- Unit tests for the operator (parent-only, transport-only, both, disabled,
preserves existing `spark_conf`) and for the helper's traversal
(single-task,
multi-task, existing-cluster skip, provider-inaccessible,
no-mutation-of-input).
- Verified on a real Databricks workspace that a `runs/submit` payload
carrying the
injected `spark.openlineage.*` properties is accepted and the properties
round-trip
unchanged (confirmed via `runs/get`), with pre-existing `spark_conf`
preserved.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.7 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
