dabla commented on PR #60458:
URL: https://github.com/apache/airflow/pull/60458#issuecomment-4602134928

   > Hello @dabla , I notice that in the commit 
[49f48e3](https://github.com/apache/airflow/commit/49f48e3bfbf5ad0062852b96599d06c02229e540)
 you modify the _http_ provider's Hook to import the pydantic BaseModel. You 
modify the `providers/apache/livy/pyproject.toml` to update the dependencies 
for the _livy_ provider, but I think that you forgot to declare the new 
dependency for the _http_ provider that now depends on pydantic being available.
   > 
   > You force `"apache-airflow-providers-http>=5.1.0"` in 
`providers/apache/livy/pyproject.toml` but `apache-airflow-providers-http` 
itself does not list pydantic as a dependency (even now in the main branch).
   
   You're right that it currently works because pydantic is pulled in 
transitively through `apache-airflow`. However, since the  
`apache-airflow-providers-http` now directly imports `pydantic`, it would be 
cleaner and more robust to declare `pydantic` as an explicit dependency of the 
provider rather than relying on a transitive dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to