Codingaditya17 commented on code in PR #67674:
URL: https://github.com/apache/airflow/pull/67674#discussion_r3342357138
##########
airflow-core/src/airflow/ui/src/components/Clear/Run/ClearRunDialog.tsx:
##########
@@ -43,6 +43,17 @@ const ClearRunDialog = ({ dagRun, onClose, open }: Props) =>
{
const { t: translate } = useTranslation();
const [note, setNote] = useState<string | null>(dagRun.note);
+
+ useEffect(() => {
+ if (open) {
+ setNote(dagRun.note);
+ }
+ }, [dagRun.note, open]);
Review Comment:
Good catch, thanks. I updated the TaskGroup mark-as flow as well.
`MarkTaskGroupAsDialog` is now always mounted and controlled through the
`open` prop, `onOpenChange` only calls the close/reset path when `details.open`
is `false`, and the note state resets on open/close like the other note-bearing
dialogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
