potiuk opened a new pull request, #439:
URL: https://github.com/apache/airflow-steward/pull/439
## Summary
Phase 3 — the first behavioral phase. Renames the two framework skills that
carried "steward" and wires the `magpie-` adoption prefix through the
setup-skill mechanism.
**Renames (source identity):**
- `setup-steward` → `setup` (`skills/setup/`)
- `list-steward-skills` → `list-skills` (`skills/list-skills/`)
- eval suites moved to `tools/skill-evals/evals/{setup,list-skills}/`
**`magpie-` adoption prefix (mechanism):** every framework skill is
installed as a `magpie-<name>` symlink into the gitignored snapshot, and the
bootstrap is **copied** as `magpie-setup`. So:
- gitignore patterns collapse from per-family lists to
`/.claude/skills/magpie-*` (+ `/.github/skills/magpie-*` for Pattern B /
canonical side for D)
- Golden rules 6 & 8, `conventions.md`, and the
`adopt`/`upgrade`/`verify`/`unadopt`/`worktree-init` symlink logic now describe
`magpie-<n>` symlink **names** pointing at clean snapshot **targets**
(`<snapshot-dir>/skills/<n>/`)
- the snapshot source path is `skills/` (PR1 relocation), picked up here for
the adopt mechanism
- the transient probe `.steward-verify-probe.tmp` →
`.magpie-verify-probe.tmp`
**Mechanism-only (as agreed):** descriptive prose keeps the clean source
names (`setup`, `list-skills`, `security-issue-import`, …); `magpie-` appears
only in invocation (`/magpie-setup`), install paths
(`.claude/skills/magpie-setup`), and gitignore.
## Out of scope (later phases)
- The **v1→v2 upgrade migration** (detecting/cleaning a v1 adopter's
`setup-steward`/un-prefixed symlinks) → PR4, the only place "steward" survives.
- `~/.config/apache-steward/` XDG dir → PR4 (entangled with the protected
`.claude/settings.json`).
- Framework-name prose "steward" and the package name `apache-steward` →
docs-name sweep (#436-style).
- The `[tool.steward.checks]` tooling-config namespace → later cleanup.
## Stacking
Branched on **#438** (dotfiles) → **#437** (skills relocation). Diff
includes those until they merge; land in order #437 → #438 → this.
## Test plan
- [x] `prek` full suite on the commit — doctoc, markdownlint, typos,
check-placeholders, ruff, ruff-format, mypy, **pytest (workspace)**,
skill-and-tool-validate all **Passed**
- [x] `skill-and-tool-validate` clean (only pre-existing soft warnings) —
caught and fixed two transform bugs (sibling-skill link targets
`../magpie-setup/` → `../setup/`; snapshot-source
`.apache-magpie/skills/magpie-setup` → `…/skills/setup`)
- [x] `uv run … skill-and-tool-validator pytest` green; eval configs load
for the renamed `evals/{setup,list-skills}/`; `list_skills.py` discovers all 38
skills from `skills/list-skills/scripts/`
- [x] Link sweep: no new broken links vs the prior phase (zero residual
`setup-steward` / `list-steward` tokens)
🤖 Prepared with AI assistance (Claude Code, Opus 4.8); reviewed by the human
author before submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
