jscheffl commented on code in PR #67532: URL: https://github.com/apache/airflow/pull/67532#discussion_r3343943937
########## providers/ibm/db2/src/airflow/providers/ibm/db2/operators/db2.py: ########## @@ -0,0 +1,187 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""IBM Db2 operator for executing SQL statements.""" + +from __future__ import annotations + +from collections.abc import Sequence +from typing import TYPE_CHECKING, Any + +from airflow.models import BaseOperator +from airflow.providers.ibm.db2.hooks.db2 import Db2Hook + +if TYPE_CHECKING: + from airflow.utils.context import Context + + +class Db2Operator(BaseOperator): Review Comment: In the past all the different database operators were consolidated into `common.sql` provider and other providers (oracle, postbres, mysql...) only describe dialects. For reference: - providers/common/sql/src/airflow/providers/common/sql/operators/sql.py - providers/postgres/src/airflow/providers/postgres/dialects/postgres.py Can you please follow this schema such that we do not require a dedicated operator? Because the common SQL operators have a common and mature functionality with just DB backend specific dialects. Other than if there is a good reason (should there be? that DB2 needs to be treated differently but I hope not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
