vincbeck commented on code in PR #67524:
URL: https://github.com/apache/airflow/pull/67524#discussion_r3348754657
##########
providers/amazon/src/airflow/providers/amazon/aws/waiters/dms.json:
##########
@@ -95,6 +95,85 @@
"state": "success"
}
]
+ },
+ "replication_task_modified": {
+ "operation": "DescribeReplicationTasks",
+ "delay": 30,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "ReplicationTasks[0].Status",
+ "expected": "modifying",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "ReplicationTasks[0].Status",
+ "expected": "stopped",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "ReplicationTasks[0].Status",
+ "expected": "ready",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "ReplicationTasks[0].Status",
+ "expected": "failed",
+ "state": "success"
Review Comment:
If the task failed, it is considered a success? Same for `stopped`?
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/dms.py:
##########
@@ -200,6 +226,48 @@ def delete_replication_task(self, replication_task_arn):
self.wait_for_task_status(replication_task_arn,
DmsTaskWaiterStatus.DELETED)
+ def modify_replication_task(
Review Comment:
This should have unit tests associated to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
