alex-stiff opened a new pull request, #67964:
URL: https://github.com/apache/airflow/pull/67964
When specifying group dependencies like `first_stage.end >>
second_stage.start`, the ordering within the Airflow UI does not respect the
default `topological` sorting.
Minimal DAG to reproduce:
```python
from datetime import datetime
from airflow.sdk import DAG, task, TaskGroup
@task
def noop_task():
pass
with DAG("grid_sort_bug_repro", start_date=datetime(2024, 1, 1),
schedule=None, catchup=False):
with TaskGroup("stage_b"):
b_start = noop_task()
b_end = noop_task()
b_start >> b_end
with TaskGroup("stage_a"):
a_start = noop_task()
a_end = noop_task()
a_start >> a_end
b_end >> a_start # task-level dep, bypasses group-level relationship
```
This shows in the grid view UI as:
```
stage_a
stage_b
```
Which is alphabetical, rather than the desired `stage_b` coming before
`stage_a`.
This is happening because the `_project_child_deps` function only checks
`child.upstream_task_ids` populated explicitly. We need to also scan the
`upstream_task_ids` of the TaskGroup's root tasks so that the tasks within the
group are also visible to this function.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
