henry3260 commented on code in PR #67900:
URL: https://github.com/apache/airflow/pull/67900#discussion_r3350665421
##########
airflow-core/newsfragments/67900.bugfix.rst:
##########
@@ -0,0 +1 @@
+Handle SQLite ``database is locked`` errors in backfill creation with
exponential-backoff retries before returning ``503 Service Unavailable``, and
add the same handling to the dry-run endpoint. Fix unpause backfill not
committing state change on SQLite.
Review Comment:
I think we don't need this one. Could we remove it?
##########
airflow-core/src/airflow/models/backfill.py:
##########
@@ -653,7 +653,7 @@ def _create_backfill(
triggering_user_name=triggering_user_name,
)
session.add(br)
- session.commit()
+ session.flush()
Review Comment:
This change widens the race window where another request cannot see the
newly created active backfill.
Concurrent requests may both pass the `num_active` check and create multiple
active backfills for the same Dag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
