GayathriSrividya commented on PR #67965:
URL: https://github.com/apache/airflow/pull/67965#issuecomment-4615518831
Good question. I checked this against #67483, and there is still a gap this
PR covers.
What #67483 fixed:
- It updated the /auth/token/login route to honor a next query param *if
present*.
What it did not change:
- SimpleAuthManager.get_url_login still ignored next_url and always returned
/auth/login or /auth/token/login without appending next.
Why this still matters:
- FAB call sites already pass next_url into get_url_login:
- providers/fab/src/airflow/providers/fab/www/auth.py
- providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py
- Because SimpleAuthManager discarded next_url, deep-link context was lost
before reaching /auth/token/login.
So #67483 handles consumption of next, while this PR handles propagation of
next into the login URL generation path.
---
Drafted-by: GitHub Copilot (GPT-5.3-Codex) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
