puneetdixit200 opened a new pull request, #67995:
URL: https://github.com/apache/airflow/pull/67995
Fixes `airflowctl dags trigger ... --conf` so JSON object values are parsed
into dictionaries before validating the generated Dag run request body.
Previously the generated parser used raw `dict`, which rejects JSON strings
such as `{ "my-key": "my-value" }`.
closes: #67989
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (OpenAI GPT-5 assisted with investigation, patch drafting, and
local verification review)
Generated-by: OpenAI GPT-5 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
## PR checklist
- [x] "closes #67989" is in the body of the PR description to [link the
related
issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] new and changed code is
[tested](https://matplotlib.org/devdocs/devel/testing.html)
- [N/A] *Plotting related* features are demonstrated in an
[example](https://matplotlib.org/devdocs/devel/document.html#write-examples-and-tutorials)
- [N/A] *New Features* and *API Changes* are noted with a [directive and
release
note](https://matplotlib.org/devdocs/devel/api_changes.html#announce-changes-deprecations-and-new-features)
- [N/A] Documentation complies with
[general](https://matplotlib.org/devdocs/devel/document.html#write-rest-pages)
and
[docstring](https://matplotlib.org/devdocs/devel/document.html#write-docstrings)
guidelines
## Local verification
- `uv run --project airflow-ctl pytest
airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py::TestCommandFactory::test_command_factory_parses_json_dict_datamodel_fields
-q` failed before the fix with `ValueError: dictionary update sequence element
#0 has length 1; 2 is required`
- `uv run --project airflow-ctl ruff format
airflow-ctl/src/airflowctl/ctl/cli_config.py
airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py`
- `uv run --project airflow-ctl ruff check --fix
airflow-ctl/src/airflowctl/ctl/cli_config.py
airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py`
- `uv run --project airflow-ctl pytest
airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py -q`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
