dabla opened a new pull request, #67999:
URL: https://github.com/apache/airflow/pull/67999
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ x ] Yes (please specify the tool below)
Claude Opus 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
This change updates MSSQL asset URI handling to support both valid path
shapes and cloud hosts:
1. mssql://<host>[:port]/<database>/<schema>/<table>
2. mssql://<host>[:port]/<instance>/<database>/<schema>/<table>
It also ensures Azure SQL (.database.windows.net) and Fabric
(.fabric.microsoft.com) URIs are accepted under the same rules.
sanitize_uri now:
• requires a host,
• defaults port to 1433 when omitted,
• accepts both 4-part and 5-part path variants (without/with instance),
• raises a clear ValueError for invalid path shapes.
convert_asset_to_openlineage now supports both URI variants by correctly
extracting database.schema.table whether an instance segment is present or not.
Tests in
providers/microsoft/mssql/tests/unit/microsoft/mssql/assets/test_mssql.py were
expanded to cover:
• Azure + Fabric success cases,
• with-instance and without-instance success cases,
• invalid path cases for both shapes,
• OpenLineage conversion with instance present.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
