uranusjr commented on code in PR #67826:
URL: https://github.com/apache/airflow/pull/67826#discussion_r3354255931
##########
dev/breeze/src/airflow_breeze/commands/developer_commands_config.py:
##########
@@ -357,8 +359,8 @@
],
"breeze build-docs": [
{
- "name": "Build scope (default is to build docs and spellcheck)",
- "options": ["--docs-only", "--spellcheck-only"],
+ "name": "Build scope (default is to build Python docs and
spellcheck)",
+ "options": ["--docs-only", "--sdk-docs-only", "--spellcheck-only"],
Review Comment:
I looked into this and it turns out not very easy. The main issue is the
Python doc builder rejects anything it does not recognize
https://github.com/apache/airflow/blob/c91dc3bb4bad9e88dfbdfdc4e6c253c29994917f/devel-common/src/sphinx_exts/docs_build/package_filter.py#L84-L87
It would be very difficult to get around this if we mix Python and
non-Python package names. It’s further complicating the filter supports
globbing, so we can’t easily exclude non-Python filters from reaching this
error without accidentally breaking existing patterns. Things like `*-sdk`
would need to both be processed by Python and non-Python doc builds, but
`java-*` can’t be passed to the Python doc build.
I think I’m going to stick with the current implementation to keep things
simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
