o-nikolas commented on code in PR #67217:
URL: https://github.com/apache/airflow/pull/67217#discussion_r3360043047
##########
airflow-core/src/airflow/executors/workloads/base.py:
##########
@@ -66,6 +66,7 @@ class BundleInfo(BaseModel):
name: str
version: str | None = None
+ version_data: dict[str, Any] | None = None
Review Comment:
Valid concern, I think it's too early to say. We'll run this as experimental
for a while and see what's really needed. The Pydantic validator that warns
above a threshold would fire once per TI enqueued (so potentially hundreds of
times per scheduler loop for a large Dag) which is a bit too noisy. So that
doesn't seem like the right move, not yet at least.
For now I'll add a docstring on version_data documenting the serialization
context (executor channels,
pod env, message brokers) and a soft size guideline (<256KB recommended).
We'll also cover this in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
