kunaljubce commented on PR #67896:
URL: https://github.com/apache/airflow/pull/67896#issuecomment-4637253724
> I looked at the code and first-hand looks reasonable but (1) I am not sure
about side effects putting a task to "running" list even if it just entered the
queue - fear there are side-effects - and (2) am not sure about the added
`raise` if this is something still used and need to be kept ignored instead of
raising an error.
>
> As not being expert in K8sExecutor and not using it would request some
other reviewer with expertise on this: @jedcunningham can you take a look or do
you know an expert if the fix is OK like this?
So regarding (2), from what I see during my testing, a `TypeError` is still
being raised with the same config -
```
if isinstance(k8s_object, k8s.V1Pod):
return k8s_object
raise TypeError(
"Cannot convert a non-kubernetes.client.models.V1Pod object into
a KubernetesExecutorConfig"
)
```
With the `raise` block I added, the intention is only to raise a more
appropriate error msg to highlight that `KubernetesExecutor` attribute is no
longer supported inside the `executor_config`.
I am happy to understand any possible issues with (1) and test it out or try
out an alternative approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
