pierrejeambrun commented on code in PR #67846:
URL: https://github.com/apache/airflow/pull/67846#discussion_r3372145049
##########
airflow-core/src/airflow/ui/src/queries/useBulkClearDagRuns.ts:
##########
@@ -99,64 +84,46 @@ export const useBulkClearDagRuns = ({ deselectKeys,
onSuccessConfirm }: Props) =
reset();
setIsPending(true);
- const settled = await Promise.allSettled(
- dagRuns.map((dagRun) =>
- DagRunService.clearDagRun({
- dagId: dagRun.dag_id,
- dagRunId: dagRun.dag_run_id,
- requestBody: {
- dry_run: false,
- note: options.note ?? undefined,
- only_failed: options.onlyFailed,
- only_new: options.onlyNew,
- },
- }).then(() => dagRun),
- ),
- );
-
- const succeeded: Array<DAGRunResponse> = [];
- const errors: Array<Record<string, unknown>> = [];
-
- settled.forEach((outcome, index) => {
- if (outcome.status === "fulfilled") {
- succeeded.push(outcome.value);
- } else {
- const dagRun = dagRuns[index];
-
- errors.push({
- error: dagRun
- ? `${getRowKey(dagRun)}: ${formatError(outcome.reason)}`
- : formatError(outcome.reason),
- });
- }
- });
+ try {
+ // ``~`` clears runs across Dags atomically in a single request; every
entry
+ // carries its own dag_id. The whole request succeeds or fails together.
+ await DagRunService.clearDagRuns({
+ dagId: "~",
+ requestBody: {
+ dag_runs: dagRuns.map((dagRun) => ({
+ dag_id: dagRun.dag_id,
Review Comment:
Implementation is consistent with, `useBulkClearTaskInstances.ts`. (Which
was my main prompt guidelines).
But I can change it here to have it cleaner.
##########
airflow-core/src/airflow/ui/src/queries/useBulkClearDagRuns.ts:
##########
@@ -99,64 +84,46 @@ export const useBulkClearDagRuns = ({ deselectKeys,
onSuccessConfirm }: Props) =
reset();
setIsPending(true);
- const settled = await Promise.allSettled(
- dagRuns.map((dagRun) =>
- DagRunService.clearDagRun({
- dagId: dagRun.dag_id,
- dagRunId: dagRun.dag_run_id,
- requestBody: {
- dry_run: false,
- note: options.note ?? undefined,
- only_failed: options.onlyFailed,
- only_new: options.onlyNew,
- },
- }).then(() => dagRun),
- ),
- );
-
- const succeeded: Array<DAGRunResponse> = [];
- const errors: Array<Record<string, unknown>> = [];
-
- settled.forEach((outcome, index) => {
- if (outcome.status === "fulfilled") {
- succeeded.push(outcome.value);
- } else {
- const dagRun = dagRuns[index];
-
- errors.push({
- error: dagRun
- ? `${getRowKey(dagRun)}: ${formatError(outcome.reason)}`
- : formatError(outcome.reason),
- });
- }
- });
+ try {
+ // ``~`` clears runs across Dags atomically in a single request; every
entry
+ // carries its own dag_id. The whole request succeeds or fails together.
+ await DagRunService.clearDagRuns({
+ dagId: "~",
+ requestBody: {
+ dag_runs: dagRuns.map((dagRun) => ({
+ dag_id: dagRun.dag_id,
Review Comment:
Implementation is consistent with `useBulkClearTaskInstances.ts`. (Which was
my main prompt guidelines).
But I can change it here to have it cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
