Miretpl commented on code in PR #68036:
URL: https://github.com/apache/airflow/pull/68036#discussion_r3374380507
##########
chart/templates/NOTES.txt:
##########
@@ -193,31 +193,6 @@ DEPRECATION WARNING:
{{- end }}
-
-{{- if .Values.securityContext }}
-
- DEPRECATION WARNING:
- `securityContext` has been renamed to `securityContexts`, to be enabled on
container and pod level.
- Please change your values as support for the old name will be dropped in a
future release.
-
-{{- end }}
-
-{{- if .Values.scheduler.securityContext }}
Review Comment:
Looking at the number of deprecation warnings here, I think that we miss
most of them in the 1.2x line. I can prepare the PR for it later today to add
the missing one.
##########
chart/tests/helm_tests/security/test_security_context.py:
##########
@@ -228,23 +171,6 @@ def test_check_local_setting_default_version(self,
workers_values):
assert
jmespath.search("spec.template.spec.securityContext.runAsUser", doc) == 9000
assert
jmespath.search("spec.template.spec.securityContext.fsGroup", doc) == 90
- # Test containerSecurity priority over uid under components using
localSecurityContext
- def test_check_local_uid(self):
Review Comment:
Do we have a similar test case with `securityContexts` (this comment is for
most of the test cases deleted within this test file)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
