goingforstudying-ctrl opened a new pull request, #68249:
URL: https://github.com/apache/airflow/pull/68249
Fixes Bug 2 from #68240.
## What
`StackdriverRemoteLogIO.read()` currently builds its Cloud Logging filter
from
`_task_instance_to_labels()`, which includes `logical_date`. In Airflow 3's
supervisor model the `REMOTE_TASK_LOG` handler runs in the supervisor
process,
which has no DB connection to convert `run_id` → `logical_date`. The filter
either crashes or returns no results.
## Fix
`read()` now constructs the filter labels directly using `run_id` instead of
`logical_date`. This matches the write path (Bug 1 / #68246) which already
emits `run_id` as a label extracted from the log path.
The `_task_instance_to_labels()` helper (used by the webserver-side
`StackdriverTaskHandler`) is left unchanged to avoid breaking log reads for
existing deployments that have `logical_date` labels.
## Changes
- Added `LABEL_RUN_ID` constant
- `StackdriverRemoteLogIO.read()` builds filter from `{dag_id, task_id,
run_id, try_number}` — no `logical_date`
- Updated tests: existing `test_read_logs` / `test_read_logs_empty`
- New test `test_read_logs_uses_run_id_filter` verifies run_id in filter and
absence of logical_date
relates to #68240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
