goingforstudying-ctrl commented on issue #68240: URL: https://github.com/apache/airflow/issues/68240#issuecomment-4652169131
Thanks for the review. A few notes on the three bugs: Bug 1 (labels): The structlog contextvar does carry task_id in the task subprocess, but in AF3's supervisor model REMOTE_TASK_LOG runs in the supervisor process where record.task_instance is never set. The contextvar on that record won't have task_id either since it's derived from the same absent attribute. The path-based fallback in #68246 only activates when task_instance is missing, so the task-subprocess code path is untouched. Bug 2 (read filter): Done as #68249. I used run_id instead of ti.id because the supervisor has no DB connection and ti.id requires one. run_id matches what the write path emits (via Bug 1's path labels). Kept _task_instance_to_labels unchanged so the webserver read path still uses logical_date for backward compat. Bug 3 (unguarded send): Done as #68250. Wrapped in try/except with a warning log. All three use 'relates to' as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
