jscheffl commented on code in PR #68198:
URL: https://github.com/apache/airflow/pull/68198#discussion_r3375956139
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -618,7 +591,7 @@ def create_dagrun(
data_interval=data_interval,
run_after=coerce_datetime(run_after),
start_date=coerce_datetime(start_date),
- conf=conf,
+ conf=conf if conf is not None else dict(copied_params),
Review Comment:
I'd propose to kick it out. And maybe making a note (but everybody working
with conf should know...) that scheduled runs carry no (or empty?) conf.
There was a longer "wish" around 2.3 years ago to consolidate params and
conf, but we missed to make this happen in Airflow 3 - so might be worth
re-discussing to consolidate both things in Airflow 4 :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
