jscheffl commented on code in PR #64422:
URL: https://github.com/apache/airflow/pull/64422#discussion_r3376109175
##########
providers/git/src/airflow/providers/git/hooks/git.py:
##########
@@ -104,10 +111,43 @@ def __init__(
self.host_proxy_cmd = extra.get("host_proxy_cmd")
self.ssh_port: int | None = int(extra["ssh_port"]) if
extra.get("ssh_port") else None
+ # GitHub App Auth Options
+ self.github_app_id = extra.get("github_app_id")
+ self.github_installation_id = extra.get("github_installation_id")
+ self.github_app_private_key: str | None = None
+ self.github_app_token_exp: datetime | None = None
+
self.env: dict[str, str] = {}
if self.key_file and self.private_key:
raise AirflowException("Both 'key_file' and 'private_key' cannot
be provided at the same time")
+ if (self.github_app_id is not None and self.github_installation_id is
None) or (
+ self.github_app_id is None and self.github_installation_id is not
None
+ ):
+ raise AirflowException(
Review Comment:
We banned (recently) to add new AirflowExceptions. Can you change to a
standard ValueError?
Same in line 132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
