Lee-W commented on code in PR #68264:
URL: https://github.com/apache/airflow/pull/68264#discussion_r3379829236
##########
task-sdk/tests/task_sdk/definitions/test_retry_policy.py:
##########
@@ -334,16 +334,16 @@ def evaluate(self, exception, try_number, max_tries,
context=None):
# ---------------------------------------------------------------------------
-# _apply_retry_policy_or_default (task_runner.py)
+# _handle_current_task_failed (task_runner.py)
Review Comment:
I think we can remove this block
##########
task-sdk/tests/task_sdk/definitions/test_retry_policy.py:
##########
@@ -31,8 +31,8 @@
RetryRule,
)
from airflow.sdk.execution_time.task_runner import (
- _apply_retry_policy_or_default,
_evaluate_retry_policy,
+ _handle_current_task_failed,
Review Comment:
could we also add tests for _finalize_task_failure? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
