nailo2c commented on PR #65511:
URL: https://github.com/apache/airflow/pull/65511#issuecomment-4663011987
I was thinking about how to do more verification for this PR, and imo this
PR basically has three major steps:
1. Generate constraints file.
2. Build images with the generated build constraints via the
`--build-constraints` flag.
3. Publish the generated constraints files to the corresponding constraints
branch. (e.g. `constraints-main`)
The PR CI already verified the first two steps (see the screenshots in the
PR description). I manually tested the third step on my local machine. The
brief steps were:
```bash
# download constraints file from the PR CI run
RUN_ID=27119122372
DRY_RUN_DIR="$(mktemp -d /tmp/airflow-constraints-dry-run.XXXXXX)"
mkdir -p "${DRY_RUN_DIR}/files"
gh run download "${RUN_ID}" \
--repo apache/airflow \
--pattern 'constraints-*' \
--dir "${DRY_RUN_DIR}/files"
git clone --depth 1 --branch constraints-main \
https://github.com/apache/airflow.git \
"${DRY_RUN_DIR}/constraints"
# execute publish step
cd "${DRY_RUN_DIR}"
./scripts/ci/constraints/ci_diff_constraints.sh
./scripts/ci/constraints/ci_commit_constraints.sh
```
Here is the result:
```console
(apache-airflow) aaron.chen@Aarons-MacBook-Air-7 airflow_2 % git -C
"${DRY_RUN_DIR}/constraints" show --name-status --stat --oneline HEAD
fc8a60f (HEAD -> constraints-main) Updating constraints. GitHub run
id:27119122372
A build-constraints-3.10.txt
M constraints-3.10.txt
M constraints-source-providers-3.10.txt
```
We can see the `build-constraints-3.10.txt` is included in the generated
constraints commit.
I hope this makes the verification more solid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
