jroachgolf84 commented on code in PR #68299:
URL: https://github.com/apache/airflow/pull/68299#discussion_r3384445587
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -2323,6 +2321,113 @@ def mock_send_side_effect(*args, **kwargs):
),
)
+ @pytest.mark.asyncio
Review Comment:
Feel free to ignore if you disagree, but it feels like there is a lot of
logic in this single unit tests, which makes it a bit difficult to understand
some of the nuance that is being tested. Do with that what you want, just
thought I'd throw my 2 cents out there.
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -3696,8 +3801,6 @@ def mock_send_side_effect(*args, **kwargs):
include_prior_dates=expected_value,
),
Review Comment:
Not trying to be that guy, but should these two lines have been removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
