somaz94 commented on code in PR #67675:
URL: https://github.com/apache/airflow/pull/67675#discussion_r3386058941
##########
chart/values.yaml:
##########
@@ -331,6 +331,55 @@ ingress:
# The Ingress Class for the PgBouncer Ingress
ingressClassName: ""
+# Kubernetes Gateway API (HTTPRoute) configuration.
+# Requires the Gateway API CRDs to be installed in the cluster
+# (https://gateway-api.sigs.k8s.io/guides/#installing-gateway-api).
+# The HTTPRoute resources reference an externally managed Gateway via
`parentRefs`.
+httpRoute:
+ # Enable all HTTPRoute resources (deprecated, use
+ # `httpRoute.apiServer.enabled`,
+ # instead). Reserved for future expansion to flower/statsd/pgbouncer.
+ enabled: ~
Review Comment:
Thanks for the review and the heads-up about #68043!
I've removed the deprecated top-level `httpRoute.enabled` toggle entirely —
from `values.yaml`, `values.schema.json`, and the template gate. The HTTPRoute
now renders solely based on `httpRoute.apiServer.enabled`, so no new deprecated
parameter is introduced and the contribution stays aligned with your
deprecation-removal effort.
While at it I also fixed the two failing CI checks (both tied to the
now-removed toggle / the vendored CRD):
- **Helm tests / apiserver**: the parametrized `test_httproute_created` had
a contradictory `(global=True, apiServer=False → not created)` row that
conflicted with the `or` gate. Dropping the global toggle removes that case,
and the test now covers only `httpRoute.apiServer.enabled`.
- **Static checks (yamllint)**: added the vendored
`gateway.networking.k8s.io_httproutes.yaml` to the yamllint exclude list,
mirroring the existing `keda.sh_scaledobjects.yaml` precedent.
Verified locally: 16 helm unit tests pass, `ruff` / `yamllint` clean, and
the values↔schema consistency test passes. Pushed in 2caf29d. PTAL 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
