henry3260 commented on code in PR #64523: URL: https://github.com/apache/airflow/pull/64523#discussion_r3389513780
########## airflow-core/src/airflow/api_fastapi/common/http_metrics.py: ########## Review Comment: > Did you look at something like https://pypi.org/project/prometheus-fastapi-instrumentator/? I chose Airflow's existing Stats abstraction so the API metrics work out-of-the-box with the currently supported StatsD, Datadog, and OTEL backends, without introducing another public endpoint or dependency. I hadn't considered exposing a Prometheus-style endpoint through `prometheus-fastapi-instrumentator`. Would you prefer replacing the Stats-based implementation with pull-style Prometheus metrics, or keeping the existing abstraction while aligning the metric names with the instrumentator's defaults? My preference would be to stick with Airflow's existing Stats abstraction, but I'm happy to align the metric names! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
