SameerMesiah97 commented on PR #68277: URL: https://github.com/apache/airflow/pull/68277#issuecomment-4674634713
> hi @SameerMesiah97 > > Thank you for the feedback! I've addressed all the comments: > > 1. Simplified the :param deferrable: docstring to a single line > 2. Moved the SparkDriverTrigger import to the top of the file > 3. Replaced AirflowException with native RuntimeError > 4. Validated status and driver_id explicitly instead of using fallback defaults > 5. Replaced the list comprehension in _build_master_rest_urls() with an explicit loop @bujjibabukatta CI is still failing. And the rest of the PR has issues. I would strongly advise you to convert this to draft and review the diff again. Then once it is ready, open it for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
