justinmclean commented on PR #474:
URL: https://github.com/apache/airflow-steward/pull/474#issuecomment-4678719114

   ## Correctness
   
   [advisory] _MIN_LICENSE_FILE_SIZE — docstring says "characters", code uses 
st_size (bytes). Equivalent for ASCII; a BOM/multi-byte stub could measure 
differently. Document as bytes.
   [advisory] test_real_repo_tool_python_files_all_have_headers calls 
find_repo_root() with no skip-guard; in a shallow checkout / out-of-tree run it 
aborts the session instead of skipping. Add a skipif.
   
   ## Conventions
   
   [advisory] Shares check-slot #8 with #481 (see cross-PR note) — whichever 
lands second renumbers.
   
   ## Security
   
   no findings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to