justinmclean commented on PR #492:
URL: https://github.com/apache/airflow-steward/pull/492#issuecomment-4678739538

   ## Correctness
   
   [advisory] release-management-lifecycle.md:8 — mode: Drafting but the spec 
text calls it "a family spanning Triage and Drafting". Single-value mode can't 
express both; add a note or extend the spec format.
   [advisory] Work-item validation blocks point at eval dirs that don't exist 
yet (release-vote-draft, issue-stale-sweep, etc.) — intentional acceptance 
targets, but a reader may misread them as broken paths.
   
   ## Conventions
   
   [advisory] IMPLEMENTATION_PLAN.md has no SPDX header (pre-existing; #474 
will catch it). Both new spec files have correct headers.
   [advisory] Validation/pytest commands use --project (your notes prefer 
--directory for skill-evals and warn against --project for pytest) — but 
mirrors existing sibling specs, so no regression.
   
   ## Security
   
   no findings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to