ashb commented on code in PR #68349:
URL: https://github.com/apache/airflow/pull/68349#discussion_r3394969896
##########
go-sdk/bundle/bundlev1/task.go:
##########
@@ -148,9 +163,10 @@ func isValidResultType(inType reflect.Type) bool {
}
var (
- errorType = reflect.TypeFor[error]()
- contextType = reflect.TypeFor[context.Context]()
- slogLoggerType = reflect.TypeFor[*slog.Logger]()
+ errorType = reflect.TypeFor[error]()
+ contextType = reflect.TypeFor[context.Context]()
+ tiRunContextType = reflect.TypeFor[sdk.TIRunContext]()
Review Comment:
I wonder if this should be a pointer.
`context.Context` isn't as that is an Interface, but TIRunContext is an
actual struct, so I think a pointer is more apt to pass? Not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
