ashb commented on code in PR #68304:
URL: https://github.com/apache/airflow/pull/68304#discussion_r3395074999
##########
providers/amazon/src/airflow/providers/amazon/aws/log/s3_task_handler.py:
##########
@@ -121,7 +119,7 @@ def write(
try:
if append and self.s3_log_exists(remote_log_location):
old_log = self.s3_read(remote_log_location)
- if old_log:
+ if old_log and not log.startswith(old_log):
Review Comment:
This seems like a _VERY_ expensive operation. Do we really need it? I'm not
clear on what the use case is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
