Chinmay1220 commented on PR #68344: URL: https://github.com/apache/airflow/pull/68344#issuecomment-4688143738
Thanks @dabla, good catch. I updated the PR to keep the previous `account_url` behavior for existing `wasb`, full URL, and custom endpoint connections. The ADLS-specific change is now limited to the case that caused the parsing issue: `conn_type == "adls"` with a bare storage account name in `host`, where `login` is a client ID for Active Directory auth. In that case we pass `account_name` so the client ID is not incorrectly used to build the storage account URL. I also updated the regression coverage to include: - existing `wasb` connections still passing `account_url` - ADLS bare account-name hosts passing `account_name` - ADLS full DFS endpoint hosts still passing `account_url` - ADLS custom endpoint hosts still passing `account_url` Could you please take another look when you have bandwidth? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
