Copilot commented on code in PR #67073:
URL: https://github.com/apache/airflow/pull/67073#discussion_r3401252440
##########
airflow-core/src/airflow/ui/public/i18n/locales/ru/hitl.json:
##########
@@ -8,9 +8,12 @@
"received": "Просмотрено"
}
},
- "requiredAction_one": "Необходимое действие",
- "requiredAction_other": "Необходимые действия",
+ "requiredAction_few": "{{count}} обязательных действия",
+ "requiredAction_many": "{{count}} обязательных действий",
+ "requiredAction_one": "{{count}} обязательное действие",
+ "requiredAction_other": "{{count}} обязательных действия",
Review Comment:
`requiredAction_*` strings now interpolate `{{count}}`, but the UI renders
`requiredAction_other` as a label without providing `count` (e.g. in
`NeedsReviewButton`), which will show the raw `{{count}}` placeholder to users.
These label strings should not require interpolation; the count-specific text
belongs in `requiredActionCount_*`.
##########
airflow-core/src/airflow/ui/public/i18n/locales/ru/admin.json:
##########
@@ -20,14 +20,19 @@
"host": "Хост",
"port": "Порт"
},
+ "connection_few": "Соединения",
+ "connection_many": "Соединений",
"connection_one": "Соединение",
- "connection_other": "Соединений",
+ "connection_other": "Соединения",
Review Comment:
`connections.connection_other` is used as a generic plural resource name
(without passing `count`) in bulk toaster messages that already prepend
`{{count}}`. With the current value ("Соединения"), messages like "5 Соединения
..." become grammatically incorrect; using genitive plural here avoids
obviously wrong output for many counts.
##########
airflow-core/src/airflow/ui/public/i18n/locales/ru/admin.json:
##########
@@ -183,7 +197,9 @@
},
"noRowsMessage": "Переменные не найдены",
"searchPlaceholder": "Поиск ключей",
+ "variable_few": "Переменные",
+ "variable_many": "Переменных",
"variable_one": "Переменная",
- "variable_other": "Переменные"
+ "variable_other": "Переменной"
Review Comment:
`variables.variable_other` is used as a generic plural resource name
(without passing `count`) in bulk toaster messages that already prepend
`{{count}}`. The current value ("Переменной") is singular, leading to incorrect
UI text like "3 Переменной ..."; it should be a plural form suitable for bulk
operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
