choo121600 opened a new pull request, #68449:
URL: https://github.com/apache/airflow/pull/68449
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
The Dag Code tab toolbar used an older button style (outline text buttons)
that
was inconsistent with the task Logs toolbar on the same Dag page. This PR
aligns both toolbars to the same icon-button pattern and interaction model:
- Replace the outline copy and wrap-text buttons with ghost icon buttons
(`LazyClipboard`, `MdWrapText`), matching the Logs toolbar
- Convert the Diff button to an icon button (`MdOutlineDifference`); it uses
the `solid` variant while the compare dropdown is open or diff mode is
active, consistent with the wrap-text toggle ("Exit diff" remains a text
button for clarity)
- Reorder actions to match the Logs toolbar: view toggles → fullscreen → copy
- Add Chakra tooltip support to `LazyClipboard` via a `label` prop, replacing
the native `title` tooltip used by the copy button in both the Code and
Logs
tabs
- Move the shared `fullscreen.tooltip` translation key from `dag:logs` to
`common` across all locales and remove the unused `fullscreen.button` key
## Before
| log | code|
|----|----|
| <img width="2168" height="1402" alt="image"
src="https://github.com/user-attachments/assets/d5a3142d-da40-4001-9538-75aed67e53c9";
/> | <img width="2168" height="1402" alt="image"
src="https://github.com/user-attachments/assets/35f46d6c-c077-45a8-a3dd-4db15239b284";
/> |
## After
<img width="2168" height="1402" alt="image"
src="https://github.com/user-attachments/assets/b046198d-4bd8-4054-9d92-bbd12a289054";
/>
<img width="2168" height="1402" alt="image"
src="https://github.com/user-attachments/assets/0b16eec1-d808-4c68-9bbd-bd13cfbe05b0";
/>
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
