jscheffl commented on PR #68078: URL: https://github.com/apache/airflow/pull/68078#issuecomment-4697831897
> @jscheffl This PR makes no sense to me. > > It's talking about Task SDK, but it doesn't import anything from in task SDK (nor should it). > > Task SDK code _should not run_ in the APi Server. Anything relying on that is fundamentally broken and breaking boundaries. If that is the reason this change is introduced then this should be reverted. #68481 Sorry, it seems I was not reading through in detail. In earlier commits that was referring to "Edge stats sent via API server not recorded" and I requested to remove Edge because this was a general shortcoming that API server did not properly initialize stats. Somehow I over-looked the "Task SDK" term. No of course Task SDK is not running in API server and this PR does not change this. But workding is still wrong. Let me have a corrective PR. Will do this in the afternoon. Note it is about commit message, exception text and comments, yes should be corrected. But still the general stats initialization was missing. Positively speaking you can read it "if Task SDK is sending something that should be recorded in stats via API server it was missing" (which was the case of Edge in 3.2). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
