dabla opened a new pull request, #68506:
URL: https://github.com/apache/airflow/pull/68506
…async tasks so we don't block the event look when resolving a hook based on
conn_id
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: [#68377](https://github.com/apache/airflow/pull/68377)
-->
## Summary
Adds `BaseHook.aget_hook()` — the missing async counterpart of
`BaseHook.get_hook()` for use in async tasks so we don't block the event loop.
## Root cause
Async tasks that called `BaseHook.get_hook()` from inside `async def` /
`aexecute()` were
inadvertently using the **sync** connection-fetch path:
```python
# Inside an async @task — wrong
hook = KiotaRequestAdapterHook.get_hook(conn_id=MSGRAPH_CONN_ID)
```
`get_hook()` calls `get_connection()` → `Connection.get()` →
`_get_connection()`, which
ultimately calls `comms.send()` — the **blocking** supervisor round-trip —
**on the event loop
thread**. Blocking the event loop thread while other coroutines are
concurrently in-flight via
`comms.asend()` causes a deadlock or severe stall.
This was the reason the issue only appeared with MSGraph and not with SFTP:
the SFTP example
used `SFTPClientPool` directly (a native async API), while the MSGraph task
called the sync
`get_hook()` from inside an async function.
## Changes
### 1. `BaseHook.aget_hook()` (`task-sdk/src/airflow/sdk/bases/hook.py`)
Provides a proper async alternative so user code never needs to call the
blocking sync path
from inside a coroutine:
```python
# Before — sync, blocks event loop
hook = KiotaRequestAdapterHook.get_hook(conn_id=MSGRAPH_CONN_ID)
# After — async, uses aget_connection() → asend() → no blocking
hook = await KiotaRequestAdapterHook.aget_hook(conn_id=MSGRAPH_CONN_ID)
```
`aget_hook()` delegates to the existing `aget_connection()`, which already
routes through
`comms.asend()` correctly.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ x ] Yes (please specify the tool below)
Claude 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
