shahar1 opened a new pull request, #68513: URL: https://github.com/apache/airflow/pull/68513
## Human Summary related: #68502, #68507 This PR removes tests that are either stdlib/3rd-party's concern, trivial attribute round-trip, or duplicated tests. Summarizing table is in the "AI Summary". ## AI Summary <details><summary>Click Here</summary> Candidates were surfaced by two detectors — per-test **coverage signatures** and an **AST scan of the whole test tree** (cross-file duplicates + dunder/stdlib + round-trip patterns) — and every one was confirmed by reading the test body, its decorators, and the production code before deletion. **Legend — patterns:** - **P1** Stdlib / third-party behavior tested directly - **P2** Trivial attribute round-trip - **P5** Exact or near-exact duplicate function | Test | File : line | Pattern | Why redundant | |---|---|---|---| | `test_state_generic` | `airflow-core/tests/unit/executors/test_base_executor.py:448` | P5 | Byte-identical body to `test_state_queued` (same `BaseExecutor.queued()` call and the two assertions on `running`/`event_buffer`); only the name differs. Kept `test_state_queued`. | | `test_empty_string_falls_back_to_default` | `airflow-core/tests/unit/logging/test_logging_config.py:60` | P5 | Fully subsumed by `test_falsy_logging_class_path_falls_back_to_default`, which is `@parametrize`d over `["", None]` and already exercises the empty-string case with the identical assertion. | | `TestCallbackSupport::test_local_executor_supports_callbacks_true` | `airflow-core/tests/unit/executors/test_base_executor.py:642` | P5 | Byte-identical, cross-file duplicate of `test_local_executor.py::TestLocalExecutorCallbackSupport::test_supports_callbacks_flag_is_true` (`LocalExecutor(); assert supports_callbacks is True`). LocalExecutor's flag belongs in `test_local_executor.py`; kept that copy. | | `test_base_job_respects_plugin_hooks` | `airflow-core/tests/unit/jobs/test_base_job.py:59` | P5 | Byte-identical to `test_state_sysexit` (runs `sys.exit(0)`, asserts `SUCCESS`) — tests nothing about plugin hooks despite its name. Real plugin coverage is the separate `test_base_job_respects_plugin_lifecycle`. | | `test_run_command_with_mode_standard` | `airflow-core/tests/unit/cli/commands/test_kerberos_command.py:124` | P5 | Byte-identical to `test_run_command` — neither passes `--mode`, both assert the `STANDARD` default. Adds no coverage beyond `test_run_command`. | | `TestRepr::test_wait_for_all_repr` | `airflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:109` | P1 | Asserts `repr(WaitForAll()) == "WaitForAll()"` — `WaitForAll` is `@attrs.define(frozen=True)` with no custom `__repr__`; this tests attrs' generated repr. | | `TestRepr::test_minimum_count_repr` | `airflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:112` | P1 | Asserts `repr(MinimumCount(5)) == "MinimumCount(n=5)"` — attrs-generated repr, no custom `__repr__` on the class. | | `TestPolicyConstruction::test_wait_for_all_is_stateless` | `airflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:53` | P1 | Asserts `WaitForAll() == WaitForAll()` and equal hashes — `@attrs.define(frozen=True)` auto-generates `__eq__`/`__hash__` for the field-less class; tests attrs, not airflow logic. | </details> --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 4.8) Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
