potiuk commented on PR #67868: URL: https://github.com/apache/airflow/pull/67868#issuecomment-4700272043
Pushed an update addressing the remaining review nits, then rebased onto latest `main`. **Changes since the last review:** - Renamed `_redact_kwargs` → `_remove_kwargs` (the value is emptied, not redacted). - Marked the `kwargs` field as `deprecated` so the OpenAPI schema now carries `deprecated: true` — this folds in the deprecation we discussed on the spec thread, and it shows up in the generated YAMLs and the UI TypeScript client (`@deprecated` JSDoc). - I went with a plain `Field(deprecated=True)` rather than a `@computed_field(deprecated=True)`: the computed-field variant emits a `DeprecationWarning` on every `model_dump()` — i.e. on every deferred-task API response — which is the "don't issue a warning from our own code" case you flagged. A plain deprecated field only warns on direct attribute access, not during serialization, so response rendering stays warning-free. The unit test reads through `model_dump()` accordingly. - Regenerated the REST + private-UI OpenAPI specs and the UI client. Also rebased onto current `main` (the branch was ~50 commits behind), which cleared a stale, unrelated `team`-field deletion the old generated specs had drifted into. --- Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
