jscheffl commented on code in PR #68360:
URL: https://github.com/apache/airflow/pull/68360#discussion_r3409307733
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py:
##########
@@ -1507,6 +1507,76 @@ def test_adopt_completed_pods_single_scheduler_unchanged(
header_params={"Accept":
"application/json;as=PartialObjectMetadataList;v=v1;g=meta.k8s.io"},
)
+ @staticmethod
+ def _completed_result(name):
+ """Build a KubernetesResults entry as ``_adopt_completed_pods`` would
add to ``self.completed``."""
+ return KubernetesResults(
+ key=TaskInstanceKey("dag", name, "run_id", 1, -1),
+ state="completed",
+ pod_name=name,
+ namespace="somens",
+ resource_version="0",
+ failure_details=None,
+ )
+
+ def _make_sync_ready_executor(self):
Review Comment:
Nit: Can you convertt this to be a pytest fixture please?
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py:
##########
@@ -1507,6 +1507,76 @@ def test_adopt_completed_pods_single_scheduler_unchanged(
header_params={"Accept":
"application/json;as=PartialObjectMetadataList;v=v1;g=meta.k8s.io"},
)
+ @staticmethod
+ def _completed_result(name):
Review Comment:
Nit: Can you convertt this to be a pytest fixture please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
