Vamsi-klu commented on code in PR #68527:
URL: https://github.com/apache/airflow/pull/68527#discussion_r3410096403
##########
providers/databricks/src/airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -445,7 +495,9 @@ def _get_aad_token_for_default_az_credential(self,
resource: str) -> str:
#
# While there is a WorkloadIdentityCredential class, the
below class is advised by Microsoft
#
https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview
- token =
DefaultAzureCredential().get_token(f"{resource}/.default")
+ token =
DefaultAzureCredential(**self._get_azure_credential_kwargs()).get_token(
Review Comment:
I wired default Azure credential flows to use the new helper-based class
selection and a shared kwargs builder so both sync/async constructors get
compatibility-safe args. I also added/kept tests to assert proxy kwargs are
included when provided and filtered correctly when unsupported constructor
params are present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
