guan404ming commented on code in PR #68232:
URL: https://github.com/apache/airflow/pull/68232#discussion_r3411091152
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_store.py:
##########
@@ -58,15 +58,20 @@ def _get_task_scope_for_ti(task_instance_id: UUID, session:
Session) -> TaskScop
return TaskScope(dag_id=ti.dag_id, run_id=ti.run_id, task_id=ti.task_id,
map_index=ti.map_index)
Review Comment:
That make sense to me. Just reverted, routes back to original sync.
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -535,10 +536,22 @@ def get(self, key: str, default: JsonValue = None) ->
JsonValue:
``datetime`` is not JSON-serializable; store it as
``value.isoformat()`` and
parse it back with ``datetime.fromisoformat(result)``.
"""
- from airflow.sdk.execution_time.comms import ErrorResponse,
GetTaskStore, TaskStoreResult
+ from airflow.sdk.execution_time.comms import GetTaskStore
from airflow.sdk.execution_time.task_runner import SUPERVISOR_COMMS
resp = SUPERVISOR_COMMS.send(GetTaskStore(ti_id=self._ti_id, key=key))
+ return self._extract_get_response(resp, key, default)
+
+ async def aget(self, key: str, default: JsonValue = None) -> JsonValue:
Review Comment:
Done, SDK-only now. Dropped the route changes; aget/aset just swap send for
await asend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
