potiuk commented on PR #68533:
URL: https://github.com/apache/airflow/pull/68533#issuecomment-4704898449
> One comment to this PR - I remember back when VirtualEnvCaching was added
that we made it a way that all tests use a cached Venv - have no oversight - is
this still true? Or do we "waste" time in the venv tests because the venv is
re-installed multiple times?
That's a good question @jscheffl -the code is still there:
```
@staticmethod
def default_kwargs(*, python_version=DEFAULT_PYTHON_VERSION, **kwargs):
kwargs["python_version"] = python_version
if "do_not_use_caching" in kwargs:
kwargs.pop("do_not_use_caching")
else:
# Caching by default makes the tests run faster except few cases
we want to test with regular venv
if "venv_cache_path" not in kwargs:
kwargs["venv_cache_path"] = venv_cache_path
return kwargs
```
It worked fine (one temp cache folder for db_tests and one-per-worker in
xdist. But I noticed we never delete those - which might cause local venv
bloat. Added ther right finalisation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
