eladkal commented on code in PR #68561: URL: https://github.com/apache/airflow/pull/68561#discussion_r3412625034
########## airflow-core/docs/best-practices.rst: ########## @@ -356,6 +356,54 @@ Running ``ruff`` will produce: By integrating ``ruff`` into your development workflow, you can proactively address deprecations and maintain code quality, facilitating smoother transitions between Airflow versions. +.. _best_practices/static_type_checking: Review Comment: Looks good but I am not sure we want it in best practices. Ideally, the length of this doc should be 0. We need to explain best practice only on things that are not self explained. so I think we should have a dedicated doc page for this and possibly just cross reference the doc from the best practices page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
