hkc-8010 commented on code in PR #66854:
URL: https://github.com/apache/airflow/pull/66854#discussion_r3414768991
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -174,34 +174,40 @@ def _default_conn_name_from(mod_path, hook_name):
from airflow.providers.amazon.aws.log.s3_task_handler import
S3RemoteLogIO
_default_conn_name_from("airflow.providers.amazon.aws.hooks.s3",
"S3Hook")
- REMOTE_TASK_LOG = S3RemoteLogIO(
- **cast(
- "dict[str, Any]",
- {
- "base_log_folder": BASE_LOG_FOLDER,
- "remote_base": remote_base_log_folder,
- "delete_local_copy": delete_local_copy,
- }
- | _io_kwargs,
- )
+ REMOTE_TASK_LOG = cast(
Review Comment:
Follow-up after rebasing onto current `upstream/main`: I removed
`airflow_local_settings.py` from the PR as well. The live PR file list is now
back to only the five asset/task-instance/metrics files, and full
`airflow-core` mypy passes locally without this file change on the current base.
One note from the push attempt: the local pre-push hook still failed in
unrelated provider mypy checks
(`providers/cncf/kubernetes/tests/unit/...test_pod.py` and
`providers/apache/spark/tests/unit/...test_spark_submit.py` both importing
`airflow.utils.timezone`). The targeted PR validation and Breeze matrix passed,
so I pushed the rebased cleanup with hooks bypassed and will monitor GitHub CI
for the actual PR result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
