kunaljubce commented on code in PR #67896:
URL: https://github.com/apache/airflow/pull/67896#discussion_r3418347646
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -227,6 +227,7 @@ def execute_async(
else:
pod_template_file = None
self.event_buffer[key] = (TaskInstanceState.QUEUED,
self.scheduler_job_id)
+ self.running.add(key)
Review Comment:
As far as I understand, full bound queue error is out of the question since
it's an unbounded queue. However, I agree with your point - other issues may
arise for sure, e.g. if the queue was closed due to executor shutdown.
So I have moved this change to after `task_queue.put()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
