jason810496 commented on code in PR #67785:
URL: https://github.com/apache/airflow/pull/67785#discussion_r3420827962
##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -714,7 +714,7 @@ def _get_log_retrieval_url(
if log_type == LogType.TRIGGER:
if not ti.triggerer_job:
raise RuntimeError("Could not build triggerer log URL; no
triggerer job.")
- config_key = "triggerer_log_server_port"
+ config_key = "trigger_log_server_port"
Review Comment:
It would be better to add a compat layer that if user is still using the
wrong `triggerer_log_server_port`, we will still respect it but raise a
warning. Else just get from the correct `trigger_log_server_port` key.
Since it has been wrong since 3 years ago, change it directly might cause
breaking change for a lots of users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
