eladkal commented on code in PR #68400:
URL: https://github.com/apache/airflow/pull/68400#discussion_r3422464885
##########
providers/clickhousedb/tests/unit/clickhousedb/hooks/test_clickhouse.py:
##########
@@ -999,6 +999,53 @@ def test_insert_rows_executemany_executes_once(self):
assert len(values) == 3
+# ---------------------------------------------------------------------------
+# Regression: executemany=True with tuple rows (clickhouse-connect >= 1.3.0)
+#
+# clickhouse_connect < 1.3.0 raised:
+# AttributeError: 'tuple' object has no attribute 'keys'
+# because Cursor._try_bulk_insert called data[0].keys() without checking
+# whether the rows were mappings or sequences (PEP 249 allows both).
+# ---------------------------------------------------------------------------
+
+
+class TestInsertRowsExecutemanyRegression:
Review Comment:
I don't know if this is needed. it feels like testing the upstream code?
I expect these defense were placed in the upstream library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
