itayweb commented on code in PR #61550:
URL: https://github.com/apache/airflow/pull/61550#discussion_r3423923220
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:
##########
@@ -451,8 +452,27 @@ def materialize_asset(
f"Dag with dag_id: '{dag_id}' does not allow asset materialization
runs",
)
+ resolved_body = body or MaterializeAssetBody()
+
+ resolved_dag_version = None
+ if resolved_body.bundle_version is not None:
+ if dag.disable_bundle_versioning:
+ raise HTTPException(
+ status.HTTP_400_BAD_REQUEST,
+ f"DAG with dag_id: '{dag_id}' does not support bundle
versioning",
Review Comment:
Done
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -1325,14 +1367,34 @@ def _create_orm_dagrun(
partition_key: str | None = None,
partition_date: datetime.datetime | None = None,
note: str | None = None,
+ bundle_version: str | None = None,
+ dag_version: DagVersion | None = None,
session: Session = NEW_SESSION,
) -> DagRun:
- bundle_version = None
- if not dag.disable_bundle_versioning:
- bundle_version = session.scalar(
- select(DagModel.bundle_version).where(DagModel.dag_id ==
dag.dag_id),
+ resolved_bundle_version: str | None = None
+ use_resolved_dag = False
+ if dag_version is not None:
+ resolved_bundle_version = bundle_version
+ use_resolved_dag = True
+ elif bundle_version is not None:
+ if dag.disable_bundle_versioning:
+ raise AirflowBadRequest(f"DAG with dag_id: '{dag.dag_id}' does not
support bundle versioning")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
