uranusjr commented on code in PR #62501:
URL: https://github.com/apache/airflow/pull/62501#discussion_r3425196977
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -137,6 +138,44 @@ def _add_one(asset: SerializedAsset) -> AssetModel:
return [_add_one(a) for a in assets]
+ @classmethod
+ def create_asset_event(cls, *, session: Session, **event_kwargs) ->
AssetEvent:
Review Comment:
This should be `_create_asset_event` instead? I don’t see the function being
used anywhere outside the manager class. Actually, this can be a free function
in the module since it does not use anything on the class at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
