23tae commented on PR #68293: URL: https://github.com/apache/airflow/pull/68293#issuecomment-4732059079
Thanks for the detailed review, @ashb. I overlooked the supervisor read path. I have updated the PR to address these points: * **Write Path:** Extracted `ti_id` directly from the `event` dict in `processors`. * **Read/Fallback Path:** Changed to safely fetch `LABEL_LOGICAL_DATE`, and added a `run_id` fallback specifically for AF3 supervisor logs. * **Tests:** Updated all `read()` tests to strictly use `spec=RuntimeTaskInstanceProtocol` in AF3+, ensuring they now properly catch missing attribute crashes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
